Enables composing shapes via DSL #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Build issues fixed. R2g. |
jwaldrop107
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
This PR enables basic composition (addition, subtraction, and multiplication) of shapes. In the process of enabling this I added/tweaked quite a bit of other infrastructure including:
DSLBaseclass for code factorization. ShapeBase, BufferBase, etc. will all interact with the DSL similarly and this mix-in should make it easier to enable the other class hierarchies in subsequent PRs.DummyIndicesare now stored inLabeledobjects.PairwiseParseris streamlined by relying onDSLBase.This PR also removes some of the DSL work I did for the
Tensor/Bufferclasses because it is not implemented with the new infrastructure (I'll add it back in subsequent PRs).TODOs
None. R2g.